Make sdk_xcode_harness similar to hello_services #2723
Conversation
|
Landing this patch will require a bunch of other changes (e.g., to the buildbot and to flutter_tools), but I wanted to post this patch to get feedback on the approach. |
|
flutter_tools changes are in flutter/flutter#4268 |
|
|
||
| action("copy_flutter_framework") { | ||
| stamp_file = "$root_build_dir/copy_flutter_framework.stamp" | ||
| script = "//sky/tools/copy_dir.py" |
There was a problem hiding this comment.
Looks like //sky/tools/copy_dir.py can be removed now
|
lgtm |
This patch makes the sdk_xcode_harness work the same way as hello_services. The goal is to eventually make these the same, but this is just a first step.
|
I tested this locally. Going to try landing it. |
|
How did you test this locally? This gets rid of the step that creates the |
|
I modified the bin/cache directory directly to contain the new bits. |
|
I see. Ok. Will add back an archive step that recreates a similar ZIP. |
|
We might not need that. The Xcode project is now independent of the build configuration because it doesn't contain any binaries. We should be headed towards the Xcode project being stable, which means we could just skip the step of finding the zip file. |
|
I think the end-state here is for the Xcode project to be generated by |
|
+1 |
New commits: git log --format="%C(auto) %h %s" 900e796..4ca4767 4ca4767 Added a dart pub outdated --transitive option (flutter#2731) 6b145bd Deprecate --server argument to `pub publish` and `pub uploader`. (flutter#2697) 7737023 don't warn if previous prerelease was null safe (flutter#2730) 62f9283 Improve outdated --mode=null-safety (flutter#2724) cc589ec Change message for no Latest resolution (flutter#2729) 656803e Require sdk constraint (flutter#2718) 8309d87 Added test that dev_dependency does not trigger null-safety warnings when publishing (flutter#2727) 332ea04 Remove warning about mixed mode. (flutter#2723) a98a1f2 Simplify null-safety analysis in `pub outdated --mode=null-safety` (flutter#2721) 5fba201 Outdated null safety implies prereleases (flutter#2722) fb9ec4a Fixed bug in yaml_edit (flutter#2703) Change-Id: I22a084aee06542e04a272269fb0134f0ac62f779 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170690 Commit-Queue: Sigurd Meldgaard <sigurdm@google.com> Reviewed-by: Michael Thomsen <mit@google.com> Reviewed-by: Jonas Jensen <jonasfj@google.com>
The warning was hard to parse - and would be triggered too often (too noisy). We can reconsider this later when we have a better feeling for the migration flow or most packages are fully migrated so we would have less noise.
3 participants
This patch makes the sdk_xcode_harness work the same way as
hello_services. The goal is to eventually make these the same, but this
is just a first step.