Skip to content

[integration_test]UIScene Migration#182631

Merged
auto-submit[bot] merged 7 commits intoflutter:masterfrom
okorohelijah:fix_174414
Mar 11, 2026
Merged

[integration_test]UIScene Migration#182631
auto-submit[bot] merged 7 commits intoflutter:masterfrom
okorohelijah:fix_174414

Conversation

@okorohelijah
Copy link
Contributor

@okorohelijah okorohelijah commented Feb 19, 2026

integration_test adopts UIScene

List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.

Fixes #174414

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin labels Feb 19, 2026
@okorohelijah okorohelijah marked this pull request as ready for review February 19, 2026 20:26
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly migrates the integration_test package to use UIScene APIs on iOS. The changes in AppDelegate and Info.plist are standard for this migration. The IntegrationTestPlugin is updated to get windows and screen bounds from the UIWindowScene, which is the correct modern approach. I have one suggestion to improve code readability and conciseness.

@okorohelijah
Copy link
Contributor Author

Based on the logs, It seems like the CI is yet to have the UIScene protocols

[2026-02-19 11:45:55.649776] [STDOUT] stdout:     - ERROR | xcodebuild:  /Volumes/Work/s/w/ir/x/w/rc/tmpci8j3cbs/flutter sdk/packages/integration_test/ios/integration_test/Sources/integration_test/include/IntegrationTestPlugin.h:11:61: error: cannot find protocol declaration for 'FlutterSceneLifeCycleDelegate'
[2026-02-19 11:45:55.649998] [STDOUT] stdout:     - ERROR | [iOS] xcodebuild:  /Volumes/Work/s/w/ir/x/w/rc/tmpci8j3cbs/flutter sdk/packages/integration_test/ios/integration_test/Sources/integration_test/IntegrationTestPlugin.m:58:14: error: no visible @interface for 'NSObject<FlutterPluginRegistrar>' declares the selector 'addSceneDelegate:'
[2026-02-19 11:45:55.650039] [STDOUT] stdout:     - ERROR | [iOS] xcodebuild:  /Volumes/Work/s/w/ir/x/w/rc/tmpci8j3cbs/flutter sdk/packages/integration_test/ios/integration_test/Sources/integration_test/IntegrationTestPlugin.m:90:53: error: property 'viewController' not found on object of type 

It seems like the CI runs pod lib lint integration_test.podspec --use-libraries and downloads the framework from cocoapods which seems to use Flutter 3.13.0 when i ran pod spec cat Flutter. We could either wait for the APIs to be integrated or make it backwards compatible

@vashworth
Copy link
Contributor

Based on the logs, It seems like the CI is yet to have the UIScene protocols

[2026-02-19 11:45:55.649776] [STDOUT] stdout:     - ERROR | xcodebuild:  /Volumes/Work/s/w/ir/x/w/rc/tmpci8j3cbs/flutter sdk/packages/integration_test/ios/integration_test/Sources/integration_test/include/IntegrationTestPlugin.h:11:61: error: cannot find protocol declaration for 'FlutterSceneLifeCycleDelegate'
[2026-02-19 11:45:55.649998] [STDOUT] stdout:     - ERROR | [iOS] xcodebuild:  /Volumes/Work/s/w/ir/x/w/rc/tmpci8j3cbs/flutter sdk/packages/integration_test/ios/integration_test/Sources/integration_test/IntegrationTestPlugin.m:58:14: error: no visible @interface for 'NSObject<FlutterPluginRegistrar>' declares the selector 'addSceneDelegate:'
[2026-02-19 11:45:55.650039] [STDOUT] stdout:     - ERROR | [iOS] xcodebuild:  /Volumes/Work/s/w/ir/x/w/rc/tmpci8j3cbs/flutter sdk/packages/integration_test/ios/integration_test/Sources/integration_test/IntegrationTestPlugin.m:90:53: error: property 'viewController' not found on object of type 

It seems like the CI runs pod lib lint integration_test.podspec --use-libraries and downloads the framework from cocoapods which seems to use Flutter 3.13.0 when i ran pod spec cat Flutter. We could either wait for the APIs to be integrated or make it backwards compatible

So this came up before in packages (flutter/packages#10484) and we decided to change it to pod lib lint --quick so that we wouldn't have to publish a new version of Flutter to CocoaPods. I think we should do the same here

@okorohelijah okorohelijah requested a review from vashworth March 3, 2026 15:46
@okorohelijah okorohelijah requested a review from vashworth March 4, 2026 19:27
@okorohelijah okorohelijah added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 11, 2026
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 11, 2026
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 11, 2026

autosubmit label was removed for flutter/flutter/182631, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR.

@okorohelijah okorohelijah added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 11, 2026
@auto-submit auto-submit bot added this pull request to the merge queue Mar 11, 2026
Merged via the queue into flutter:master with commit 3a9e7a9 Mar 11, 2026
153 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 11, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2026
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Mar 12, 2026
flutter/flutter@3f400d7...9e36adb

2026-03-12 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from QD887D4OanteB7UKM... to jJbpv4J_tjW-wuKDq... (flutter/flutter#183584)
2026-03-12 matt.kosarek@canonical.com Adding the SatelliteWindowController interface to `_window.dart` (flutter/flutter#182903)
2026-03-12 engine-flutter-autoroll@skia.org Roll Skia from 0cab3e4ee34b to 46f41493ebf4 (17 revisions) (flutter/flutter#183553)
2026-03-12 engine-flutter-autoroll@skia.org Roll Dart SDK from 8531f7c2bdae to 59be21f25f2d (4 revisions) (flutter/flutter#183547)
2026-03-12 koji.wakamiya@gmail.com [ios][engine] Fix keyboard flicker when switching text fields (flutter/flutter#182661)
2026-03-11 34871572+gmackall@users.noreply.github.com Rename hcpp opt in flag to `enable-hcpp` (flutter/flutter#183151)
2026-03-11 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#183541)
2026-03-11 97480502+b-luk@users.noreply.github.com Re-enable gpu_test.dart for opengles, but disable specific tests in the file (flutter/flutter#183531)
2026-03-11 jacksongardner@google.com Use CLA-approved email and username for github workflow commits. (flutter/flutter#183540)
2026-03-11 okorohelijah@google.com [integration_test]UIScene Migration (flutter/flutter#182631)
2026-03-11 git@reb0.org ci: Run orchestrator for windows_arm_host_engine on Linux  (flutter/flutter#181075)
2026-03-11 mdebbar@google.com [web] Prevent Firefox auto-updates (flutter/flutter#183330)
2026-03-11 koji.wakamiya@gmail.com Add scrollCacheExtent to PageView (flutter/flutter#180411)
2026-03-11 danny@tuppeny.com Remove redundant VS Code code/tests (flutter/flutter#183506)
2026-03-11 danny@tuppeny.com Roll pub packages (flutter/flutter#183527)
2026-03-11 34871572+gmackall@users.noreply.github.com Reapply "Make HCPP upgrading work for vd/tlhc (#181024)" (#183310) (flutter/flutter#183360)
2026-03-11 victorsanniay@gmail.com Add awaits to dev/ callsites (flutter/flutter#183479)
2026-03-11 stuartmorgan@google.com Standardize review timeline guidance (flutter/flutter#183465)
2026-03-11 chingjun@google.com Rename ExecutionModelToString to ExecutionModelToStringName. (flutter/flutter#183461)
2026-03-11 34871572+gmackall@users.noreply.github.com Fix input mirroring in platform views when system language is RTL, and support is set in manifest. (flutter/flutter#183472)
2026-03-11 engine-flutter-autoroll@skia.org Roll Packages from ee460d6 to ecace66 (10 revisions) (flutter/flutter#183517)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[integration_test][UIScene] Migrate to scene APIs

2 participants