Replace usages of `MediaQuery.of(context).property` with `MediaQuery.propertyOf(context)` by AbdeMohlbi · Pull Request #184211 · flutter/flutter

AbdeMohlbi · 2026-03-26T17:34:27Z

This change replaces the following usages:

MediaQuery.of(context).size.width with MediaQuery.widthOf(context)
MediaQuery.of(context).size.height with MediaQuery.heightOf(context)

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

gemini-code-assist

Code Review

This pull request replaces MediaQuery.of(context).size accessors with the more specific MediaQuery.widthOf(context) and MediaQuery.heightOf(context) methods across various benchmarks, examples, and tests to optimize performance. Review feedback identifies dead code in dynamic_content_color.0.dart, suggests refactoring duplicated image resizing logic in large_image_changer.dart, and recommends using MediaQuery.sizeOf(context) in components that require both dimensions to improve efficiency and readability.

navaronbracke

While the change overall is LGTM, I think you can also avoid the widthOf() + heightOf() double round trip, by using sizeOf() in these areas.

navaronbracke · 2026-03-27T19:19:56Z

  ) {
-    final double windowHeight = MediaQuery.of(context).size.height;
-    final double windowWidth = MediaQuery.of(context).size.width;
+    final double windowHeight = MediaQuery.heightOf(context);


Technically you can use final Size size = MediaQuery.sizeOf(context); here as well, and delegate to the size.

…ediaQuery.propertyOf(context)` (flutter/flutter#184211)

flutter/flutter@3d69471...0f401ee 2026-04-02 matej.knopp@gmail.com Remove isSizedToContent from _window_linux.dart. (flutter/flutter#184506) 2026-04-02 matej.knopp@gmail.com Windows: Get graphics adapter from engine instead of view (flutter/flutter#184479) 2026-04-02 robert.ancell@canonical.com Reduce number of mallocs in FFI call (flutter/flutter#184166) 2026-04-02 robert.ancell@canonical.com Handle events without a device (flutter/flutter#184163) 2026-04-02 robert.ancell@canonical.com Implement tooltip windows on Linux (flutter/flutter#182348) 2026-04-02 engine-flutter-autoroll@skia.org Roll Skia from bdeebacf23c8 to bb9fd8653739 (4 revisions) (flutter/flutter#184494) 2026-04-02 matej.knopp@gmail.com Implement popup windows for macOS (flutter/flutter#182371) 2026-04-02 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from fV-JIWUt4FQGeDtEe... to BFLjk6Uwd0gs_Hkdk... (flutter/flutter#184492) 2026-04-02 victorsanniay@gmail.com Add await or ignore to future-returning methods defined in Dart SDK (flutter/flutter#184229) 2026-04-02 engine-flutter-autoroll@skia.org Roll Dart SDK from 043a2bfd56ff to d84bdfeb45eb (2 revisions) (flutter/flutter#184487) 2026-04-01 engine-flutter-autoroll@skia.org Roll Skia from c2363c39c283 to bdeebacf23c8 (9 revisions) (flutter/flutter#184480) 2026-04-01 ksanaullah383.khan@gmail.com Remove sliver_test_utils cross-import from sliver_app_bar_test (flutter/flutter#184193) 2026-04-01 116356835+AbdeMohlbi@users.noreply.github.com Improve error message when `dart-define` content are not `base64 encoded` and add more test cases (flutter/flutter#184219) 2026-04-01 116356835+AbdeMohlbi@users.noreply.github.com Replace usages of `MediaQuery.of(context).property` with `MediaQuery.propertyOf(context)` (flutter/flutter#184211) 2026-04-01 techonlabs@gmail.com [ios] Add opt-in inline prediction text input support (flutter/flutter#183650) 2026-04-01 jesswon@google.com [fix-forward] fix build_android_host_app_with_module_source integration test (flutter/flutter#184466) 2026-04-01 katelovett@google.com Update style guide (flutter/flutter#184478) 2026-04-01 engine-flutter-autoroll@skia.org Roll Packages from b04f3e5 to b3fcf14 (3 revisions) (flutter/flutter#184474) 2026-04-01 15619084+vashworth@users.noreply.github.com Warn about slow SwiftPM downloads and centralize SwiftPM cache (flutter/flutter#183747) 2026-04-01 15619084+vashworth@users.noreply.github.com Inject FlutterFramework dependency in iOS Add2App swift packages (flutter/flutter#184365) 2026-04-01 1063596+reidbaker@users.noreply.github.com Prepare for skills adoption (flutter/flutter#184129) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC louisehsu@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…propertyOf(context)` (flutter#184211) This change replaces the following usages: - `MediaQuery.of(context).size.width` with `MediaQuery.widthOf(context)` - `MediaQuery.of(context).size.height` with `MediaQuery.heightOf(context)` ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

use property of

a361b77

AbdeMohlbi added the CICD Run CI/CD label Mar 26, 2026

AbdeMohlbi changed the title ~~use property of~~ Replace usages of MediaQuery.of(context).property with MediaQuery.propertyOf(context) Mar 26, 2026

AbdeMohlbi marked this pull request as ready for review March 26, 2026 18:44

gemini-code-assist Bot reviewed Mar 26, 2026

View reviewed changes

navaronbracke requested changes Mar 27, 2026

View reviewed changes

Comment thread dev/benchmarks/macrobenchmarks/lib/src/very_long_picture_scrolling.dart Outdated

address comments from code review

8cbffa5

github-actions Bot removed the CICD Run CI/CD label Mar 27, 2026

AbdeMohlbi added the CICD Run CI/CD label Mar 27, 2026

AbdeMohlbi requested a review from navaronbracke March 27, 2026 15:37

navaronbracke previously approved these changes Mar 27, 2026

View reviewed changes

Comment thread dev/benchmarks/macrobenchmarks/lib/src/very_long_picture_scrolling.dart

restore blank

8223a07

AbdeMohlbi dismissed navaronbracke’s stale review via 8223a07 March 27, 2026 17:45

github-actions Bot removed the CICD Run CI/CD label Mar 27, 2026

AbdeMohlbi requested a review from navaronbracke March 27, 2026 17:45

AbdeMohlbi added the CICD Run CI/CD label Mar 27, 2026

navaronbracke reviewed Mar 27, 2026

View reviewed changes

navaronbracke approved these changes Mar 27, 2026

View reviewed changes

dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 1, 2026

victorsanni approved these changes Apr 1, 2026

View reviewed changes

auto-submit Bot added this pull request to the merge queue Apr 1, 2026

Merged via the queue into flutter:master with commit 16b4ae4 Apr 1, 2026
159 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 1, 2026

engine-flutter-autoroll mentioned this pull request Apr 2, 2026

Roll Flutter from 3d69471c0bf9 to 0f401eea0439 (21 revisions) flutter/packages#11419

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 2, 2026

16b4ae45a Replace usages of MediaQuery.of(context).property with `M…

ff365db

…ediaQuery.propertyOf(context)` (flutter/flutter#184211)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 2, 2026

16b4ae45a Replace usages of MediaQuery.of(context).property with `M…

fc51823

…ediaQuery.propertyOf(context)` (flutter/flutter#184211)

engine-flutter-autoroll mentioned this pull request Apr 2, 2026

Roll Flutter from 3d69471c0bf9 to 0f401eea0439 (21 revisions) flutter/packages#11420

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace usages of `MediaQuery.of(context).property` with `MediaQuery.propertyOf(context)`#184211

Replace usages of `MediaQuery.of(context).property` with `MediaQuery.propertyOf(context)`#184211
auto-submit[bot] merged 3 commits into
flutter:masterfrom
AbdeMohlbi:use_MediaQuery_propertyOf

AbdeMohlbi commented Mar 26, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

navaronbracke left a comment

Uh oh!

Uh oh!

Uh oh!

navaronbracke Mar 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

AbdeMohlbi commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

navaronbracke left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

navaronbracke Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

AbdeMohlbi commented Mar 26, 2026 •

edited

Loading