Remove deprecated describeEnum from framework - #190076
Conversation
github-actions
Bot
added
the
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
navaronbracke
left a comment
navaronbracke
left a comment
There was a problem hiding this comment.
LGTM
According to https://github.com/search?q=repo%3Aflutter%2Fflutter%20describeEnum&type=code
there's only these two usages, so I think we're good!
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
We should open a migration guide in flutter/website to have this listed under breaking changes when it is released
Is there an example that i could look at ? |
Yup yup! flutter/website#13457 is an example. There is a template in https://github.com/flutter/website/blob/main/sites/docs/src/content/release/breaking-changes/template.md |
opened flutter/website#13682 |
3 participants
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.