iOS: Hardcode rendering API to Metal in tests (no-op) - #190422
Merged
Conversation
Some of our tests were selecting a rendering API between kMetal and kSoftware. On iOS we no longer support any backend other than Metal. `enable_impeller` is a `static constexpr const bool` that's hardcoded to `true`, so these expressions always evaluate to `kMetal`; the `kSoftware` arm is dead code. This replaces the ternaries with `kMetal` to clean up the code and save the compiler a few microseconds. This removes the last references to `IOSRenderingAPI::kSoftware` outside the no-Metal fallback itself. I'll send a follow-up to delete that. No changes to behaviour, and really no change to the compiled tests for that matter.
github-actions
Bot
added
a: text input
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates several test files for the iOS platform view and accessibility bridge by hardcoding the rendering_api parameter to flutter::IOSRenderingAPI::kMetal during the instantiation of flutter::PlatformViewIOS, removing the previous conditional check based on the enable_impeller setting. There are no review comments, and I have no feedback to provide.
LongCatIsLooong
approved these changes
Aug 3, 2026
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of our tests were selecting a rendering API between kMetal and kSoftware. On iOS we no longer support any backend other than Metal.
enable_impelleris astatic constexpr const boolthat's hardcoded totrue, so these expressions always evaluate tokMetal; thekSoftwarearm is dead code. This replaces the ternaries withkMetalto clean up the code and save the compiler a few microseconds.This removes the last references to
IOSRenderingAPI::kSoftwareoutside the no-Metal fallback itself. I'll send a follow-up to delete that.No changes to behaviour, and really no change to the compiled tests for that matter.
Issue: #190041
Issue: #112232
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.