iOS: Remove the IOSRenderingAPI selection code - #190636
Merged
Merged
Conversation
github-actions
Bot
added
a: text input
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the IOSRenderingAPI enum and its associated selection plumbing across the iOS platform view implementation, including PlatformViewIOS, IOSContext, and related tests, as Metal is now the sole rendering API. The review feedback suggests renaming GetCoreAnimationLayerClassForRenderingAPI to GetCoreAnimationLayerClass to reflect the removal of the rendering API parameter, along with updating its definition and call site.
Flutter iOS requires Metal. Skia support has been removed. Impeller has no software fallback. `IOSRenderingAPI` had one value (`kMetal`) and `GetRenderingAPIForProcess` only ever returned that value after asserting Metal was available. This removes the enum and the selection plumbing that was threaded through the engine, view, platform view, and context. `GetCoreAnimationLayerClassForRenderingAPI` still returns `FlutterMetalLayer` or `CAMetalLayer` depending on embedder settings. Issue: flutter#190041
cbracken
force-pushed
the
cleanup-delete-iosrenderingapi
branch
from
August 6, 2026 00:23
8097bd4 to
5b57281
Compare
hellohuanlin
approved these changes
Aug 6, 2026
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flutter iOS requires Metal. Skia support has been removed. Impeller has no software fallback.
IOSRenderingAPIhad one value (kMetal) andGetRenderingAPIForProcessonly ever returned that value after asserting Metal was available. This removes the enum and the selection plumbing that was threaded through the engine, view, platform view, and context.GetCoreAnimationLayerClassForRenderingAPIstill returnsFlutterMetalLayerorCAMetalLayerdepending on embedder settings.Issue: #190041
Issue: #112232
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.