Tests for Engine ensuring debug-mode apps are attached on iOS.#37043
Merged
sjindel-google merged 7 commits intoflutter:masterfrom Aug 6, 2019
Merged
Tests for Engine ensuring debug-mode apps are attached on iOS.#37043sjindel-google merged 7 commits intoflutter:masterfrom
sjindel-google merged 7 commits intoflutter:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #37043 +/- ##
==========================================
+ Coverage 54.21% 55.33% +1.12%
==========================================
Files 191 190 -1
Lines 17788 17567 -221
==========================================
+ Hits 9644 9721 +77
+ Misses 8144 7846 -298
Continue to review full report at Codecov.
|
Contributor
Author
|
I don't think the patch coverage is meaningful here because these tests can only run on devicelab and not in the CI tests. |
jonahwilliams
approved these changes
Aug 1, 2019
Contributor
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM
Yes I wouldn't worry about the patch coverage
Contributor
Author
|
@chinmaygarde Chinmay, could you please take another look at this one? |
chinmaygarde
approved these changes
Aug 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the tests for flutter/engine#10186.