Skip to content

Tests for Engine ensuring debug-mode apps are attached on iOS.#37043

Merged
sjindel-google merged 7 commits intoflutter:masterfrom
sjindel-google:test
Aug 6, 2019
Merged

Tests for Engine ensuring debug-mode apps are attached on iOS.#37043
sjindel-google merged 7 commits intoflutter:masterfrom
sjindel-google:test

Conversation

@sjindel-google
Copy link
Copy Markdown
Contributor

This PR contains the tests for flutter/engine#10186.

@fluttergithubbot fluttergithubbot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Jul 26, 2019
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 26, 2019

Codecov Report

Merging #37043 into master will increase coverage by 1.12%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37043      +/-   ##
==========================================
+ Coverage   54.21%   55.33%   +1.12%     
==========================================
  Files         191      190       -1     
  Lines       17788    17567     -221     
==========================================
+ Hits         9644     9721      +77     
+ Misses       8144     7846     -298
Flag Coverage Δ
#flutter_tool 55.33% <50%> (+1.12%) ⬆️
Impacted Files Coverage Δ
packages/flutter_tools/lib/src/ios/devices.dart 36.92% <0%> (+0.26%) ⬆️
packages/flutter_tools/lib/src/commands/drive.dart 75% <100%> (+0.42%) ⬆️
packages/flutter_tools/lib/src/android/gradle.dart 18.94% <0%> (-23.48%) ⬇️
packages/flutter_tools/lib/src/services.dart 0% <0%> (ø) ⬆️
packages/flutter_tools/lib/src/build_info.dart 69.61% <0%> (ø) ⬆️
...utter_tools/lib/src/build_runner/build_script.dart 0% <0%> (ø) ⬆️
...flutter_tools/lib/src/vmservice_record_replay.dart 0% <0%> (ø) ⬆️
...ackages/flutter_tools/lib/src/android/android.dart
...lutter_tools/lib/src/commands/update_packages.dart 3.9% <0%> (+0.27%) ⬆️
packages/flutter_tools/lib/src/doctor.dart 70.18% <0%> (+0.3%) ⬆️
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3068fc4...d24d3b9. Read the comment docs.

@sjindel-google
Copy link
Copy Markdown
Contributor Author

I don't think the patch coverage is meaningful here because these tests can only run on devicelab and not in the CI tests.

Copy link
Copy Markdown
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Yes I wouldn't worry about the patch coverage

@sjindel-google
Copy link
Copy Markdown
Contributor Author

@chinmaygarde Chinmay, could you please take another look at this one?

@sjindel-google sjindel-google merged commit 0564f0a into flutter:master Aug 6, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants