Skip to content

run web tests in batches; enable foundation tests#37268

Merged
yjbanov merged 2 commits intoflutter:masterfrom
yjbanov:enable-web-tests
Aug 23, 2019
Merged

run web tests in batches; enable foundation tests#37268
yjbanov merged 2 commits intoflutter:masterfrom
yjbanov:enable-web-tests

Conversation

@yjbanov
Copy link
Copy Markdown
Contributor

@yjbanov yjbanov commented Jul 30, 2019

Description

Change the way we run Web tests. Instead of running all tests in a single browser instance, tests are divided into batches (20 tests per batch) and each batch gets its own dedicated browser instance. The browser is shut down and restarted between batches so it does not accumulate state that could potentially get corrupted, leading to flakiness.

This change also runs all foundation tests as a test batch. If it's stable enough we'll enable more tests in subsequent PRs.

Related Issues

#37258

Tests

There no new code to add tests for.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@yjbanov yjbanov force-pushed the enable-web-tests branch from 5f4dd0d to a5ce62f Compare July 31, 2019 18:19
@Piinks Piinks added the platform-web Web applications specifically label Aug 6, 2019
@yjbanov yjbanov changed the title Enable web tests run web tests in batches; enable foundation tests Aug 22, 2019
Copy link
Copy Markdown
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yjbanov yjbanov merged commit 190698d into flutter:master Aug 23, 2019
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

platform-web Web applications specifically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants