run web tests in batches; enable foundation tests#37268
Merged
yjbanov merged 2 commits intoflutter:masterfrom Aug 23, 2019
Merged
run web tests in batches; enable foundation tests#37268yjbanov merged 2 commits intoflutter:masterfrom
yjbanov merged 2 commits intoflutter:masterfrom
Conversation
5f4dd0d to
a5ce62f
Compare
a5ce62f to
f37c2e7
Compare
f37c2e7 to
e25b206
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change the way we run Web tests. Instead of running all tests in a single browser instance, tests are divided into batches (20 tests per batch) and each batch gets its own dedicated browser instance. The browser is shut down and restarted between batches so it does not accumulate state that could potentially get corrupted, leading to flakiness.
This change also runs all foundation tests as a test batch. If it's stable enough we'll enable more tests in subsequent PRs.
Related Issues
#37258
Tests
There no new code to add tests for.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?