have android_semantics_testing use adb from ENV provided android sdk#37828
Merged
christopherfujino merged 1 commit intoflutter:masterfrom Aug 8, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While running the devicelab tests on a brand new mac, I had
android_semantics_integration_testfail because theadbfile could not be found (though I had provided anANDROID_SDK_ROOTenv variable. While the devicelab test runner will read the env variable and use it, this particular test manually invokedadbfrom path to turn on and off the talkback accessibility feature. This PR updates the test to first check for the env vars and use theadbbinary from them if provided, and if not default back to thePATHversion.This assures that we are using the provided version of
adb.Related Issues
Found this myself.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?