Skip to content

have android_semantics_testing use adb from ENV provided android sdk#37828

Merged
christopherfujino merged 1 commit intoflutter:masterfrom
chris-forks:have-android-semantics-testing-use-provided-sdk-adb
Aug 8, 2019
Merged

have android_semantics_testing use adb from ENV provided android sdk#37828
christopherfujino merged 1 commit intoflutter:masterfrom
chris-forks:have-android-semantics-testing-use-provided-sdk-adb

Conversation

@christopherfujino
Copy link
Copy Markdown
Contributor

Description

While running the devicelab tests on a brand new mac, I had android_semantics_integration_test fail because the adb file could not be found (though I had provided an ANDROID_SDK_ROOT env variable. While the devicelab test runner will read the env variable and use it, this particular test manually invoked adb from path to turn on and off the talkback accessibility feature. This PR updates the test to first check for the env vars and use the adb binary from them if provided, and if not default back to the PATH version.

This assures that we are using the provided version of adb.

Related Issues

Found this myself.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. labels Aug 8, 2019
Copy link
Copy Markdown
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino christopherfujino merged commit 771c843 into flutter:master Aug 8, 2019
@christopherfujino christopherfujino deleted the have-android-semantics-testing-use-provided-sdk-adb branch August 8, 2019 20:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants