Skip to content

Kill dead code#38652

Merged
dnfield merged 3 commits intoflutter:masterfrom
dnfield:remove_jit_snapshotter
Aug 16, 2019
Merged

Kill dead code#38652
dnfield merged 3 commits intoflutter:masterfrom
dnfield:remove_jit_snapshotter

Conversation

@dnfield
Copy link
Copy Markdown
Contributor

@dnfield dnfield commented Aug 15, 2019

This code is not used anywhere.

@dnfield dnfield requested a review from jonahwilliams August 15, 2019 21:31
@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 15, 2019
@dnfield dnfield requested a review from zanderso August 15, 2019 21:31
@dnfield dnfield added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Aug 15, 2019
Copy link
Copy Markdown
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 15, 2019

Codecov Report

Merging #38652 into master will decrease coverage by 0.53%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38652      +/-   ##
==========================================
- Coverage   56.26%   55.72%   -0.54%     
==========================================
  Files         195      195              
  Lines       18304    18251      -53     
==========================================
- Hits        10298    10170     -128     
- Misses       8006     8081      +75
Flag Coverage Δ
#flutter_tool 55.72% <ø> (-0.54%) ⬇️
Impacted Files Coverage Δ
packages/flutter_tools/lib/src/base/build.dart 68.03% <ø> (-5.69%) ⬇️
...lutter_tools/lib/src/build_system/targets/ios.dart 0% <0%> (-76.6%) ⬇️
...utter_tools/lib/src/build_system/targets/dart.dart 49.2% <0%> (-25.4%) ⬇️
packages/flutter_tools/lib/src/macos/xcode.dart 42.85% <0%> (-10.72%) ⬇️
...ackages/flutter_tools/lib/src/commands/daemon.dart 24.65% <0%> (-9.54%) ⬇️
packages/flutter_tools/lib/src/device.dart 54.81% <0%> (-2.41%) ⬇️
packages/flutter_tools/lib/src/artifacts.dart 65.6% <0%> (-2.13%) ⬇️
packages/flutter_tools/lib/src/context_runner.dart 66.66% <0%> (-1.97%) ⬇️
packages/flutter_tools/lib/src/version.dart 90.73% <0%> (-1.96%) ⬇️
packages/flutter_tools/lib/src/build_info.dart 69.94% <0%> (-1.64%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a4d3cd...0f99418. Read the comment docs.

@dnfield dnfield merged commit a322166 into flutter:master Aug 16, 2019
@dnfield dnfield deleted the remove_jit_snapshotter branch August 16, 2019 17:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants