Use dpr and window size from binding for accessibility guide#39577
Merged
jonahwilliams merged 1 commit intoflutter:masterfrom Sep 2, 2019
Merged
Use dpr and window size from binding for accessibility guide#39577jonahwilliams merged 1 commit intoflutter:masterfrom
jonahwilliams merged 1 commit intoflutter:masterfrom
Conversation
fluttergithubbot
added
a: tests
Contributor
Author
|
cc @johnsonmh, can you double check that this works for you? |
jonahwilliams
changed the title
johnsonmh
approved these changes
Aug 30, 2019
Contributor
johnsonmh
left a comment
johnsonmh
left a comment
There was a problem hiding this comment.
LGTM, this solution works for me, thanks for the quick PR Jonah!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously the contrast test logic assumed 800x600 and a dpr of 3.0. Remove the hardcoded values and replace with a lookup on the binding's window to support different screen sizes and resolutions.