Skip to content

Remove input files argument to target#39701

Merged
jonahwilliams merged 1 commit intoflutter:masterfrom
jonahwilliams:remove_inputs
Sep 3, 2019
Merged

Remove input files argument to target#39701
jonahwilliams merged 1 commit intoflutter:masterfrom
jonahwilliams:remove_inputs

Conversation

@jonahwilliams
Copy link
Copy Markdown
Contributor

Description

These are not really useful and mostly clutters up the API. Was only used by linux and windows copy rules, that was replaced with the artifact source.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 2, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 2, 2019

Codecov Report

Merging #39701 into master will increase coverage by 0.71%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39701      +/-   ##
==========================================
+ Coverage   56.27%   56.98%   +0.71%     
==========================================
  Files         194      194              
  Lines       18676    18632      -44     
==========================================
+ Hits        10509    10618     +109     
+ Misses       8167     8014     -153
Flag Coverage Δ
#flutter_tool 56.98% <77.77%> (+0.71%) ⬆️
Impacted Files Coverage Δ
...utter_tools/lib/src/build_system/targets/dart.dart 4.68% <0%> (-71.88%) ⬇️
...lutter_tools/lib/src/build_system/targets/ios.dart 4.25% <0%> (-74.47%) ⬇️
...er_tools/lib/src/build_system/targets/windows.dart 94.11% <100%> (+0.36%) ⬆️
...utter_tools/lib/src/build_system/build_system.dart 92.55% <100%> (ø) ⬆️
...tter_tools/lib/src/build_system/targets/linux.dart 94.44% <100%> (+0.32%) ⬆️
...ter_tools/lib/src/build_system/targets/assets.dart 87.27% <100%> (ø) ⬆️
...tter_tools/lib/src/build_system/targets/macos.dart 47.61% <75%> (ø) ⬆️
...ckages/flutter_tools/lib/src/commands/version.dart 4.34% <0%> (-89.14%) ⬇️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3f8d05...0c87b48. Read the comment docs.

@jonahwilliams jonahwilliams merged commit 5e7beaf into flutter:master Sep 3, 2019
jonahwilliams pushed a commit that referenced this pull request Sep 3, 2019
jonahwilliams pushed a commit that referenced this pull request Sep 3, 2019
@jonahwilliams
Copy link
Copy Markdown
Contributor Author

Accidentally merged this (rolled back), don't talk and type!

@jonahwilliams jonahwilliams deleted the remove_inputs branch September 5, 2019 16:56
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants