replace package:vm_service_client with package:vm_service in the devicelab project

[devoncarew]

Description

Replace package:vm_service_client with package:vm_service in the devicelab project. This is to reduce the number of vm service client libraries in use in flutter/flutter.

After this PR, there will still be some uses of vm_service_client in flutter_driver and flutter_tools.

Tests

• this PR relies on existing tests (and specifically, that the devicelab test system continues to work when using the new package)

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I signed the CLA.
• I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
• I updated/added relevant documentation (doc comments with ///).
• All existing and new tests are passing.
• The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
• I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

• Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
• No, this is not a breaking change.

@zanderso and @jonahwilliams for review; @bkonyi for FYI

[jonahwilliams]

LGTM

Thanks for helping with the cleanup!

[zanderso]

lgtm thanks!

[codecov]

Codecov Report

Merging #41646 into master will decrease coverage by 0.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #41646      +/-   ##
==========================================
- Coverage   60.52%   60.26%   -0.27%     
==========================================
  Files         193      193              
  Lines       18891    18893       +2     
==========================================
- Hits        11434    11386      -48     
- Misses       7457     7507      +50

Flag	Coverage Δ
#flutter_tool	60.26% <ø> (-0.27%)	⬇️

Impacted Files	Coverage Δ
...lutter_tools/lib/src/commands/update_packages.dart	3.68% <ø> (ø)	⬆️
...lutter_tools/lib/src/build_system/targets/ios.dart	4.25% <0%> (-74.47%)	⬇️
...ter_tools/lib/src/build_system/targets/assets.dart	1.33% <0%> (-62.67%)	⬇️
...utter_tools/lib/src/build_system/targets/dart.dart	24.24% <0%> (-23.24%)	⬇️
packages/flutter_tools/lib/src/macos/xcode.dart	51.66% <0%> (-10%)	⬇️
...ges/flutter_tools/lib/src/build_system/source.dart	77.55% <0%> (-6.13%)	⬇️
packages/flutter_tools/lib/src/artifacts.dart	67.93% <0%> (-2.07%)	⬇️
packages/flutter_tools/lib/src/version.dart	91.9% <0%> (-1.43%)	⬇️
packages/flutter_tools/lib/src/cache.dart	45.31% <0%> (-0.67%)	⬇️
packages/flutter_tools/lib/src/commands/run.dart	64.39% <0%> (-0.49%)	⬇️
... and 9 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11d0235...2971c40. Read the comment docs.