Revert "Dsiable CPU/GPU measurement on BackdropFilter test (#41736)"#41780
Merged
gspencergoog merged 1 commit intoflutter:masterfrom Oct 2, 2019
Merged
Revert "Dsiable CPU/GPU measurement on BackdropFilter test (#41736)"#41780gspencergoog merged 1 commit intoflutter:masterfrom
gspencergoog merged 1 commit intoflutter:masterfrom
Conversation
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
fluttergithubbot
added
the
c: contributor-productivity
Contributor
Author
|
/cc @liyuqian |
Contributor
|
LGTM |
Contributor
Author
|
Indeed, this did not fix the build problems. @liyuqian, feel free to re-land this. |
Contributor
|
Sure, reverting this. Thank you for the attempt :) |
liyuqian
added a commit
that referenced
this pull request
Oct 2, 2019
liyuqian
added a commit
that referenced
this pull request
Oct 2, 2019
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
…1736)" (flutter#41780) This reverts c9d920f so that we can attempt to fix the build. The build dashboard clearly shows that things started failing at this change, although it's not totally clear that it is the cause: tests succeed locally. If it doesn't fix things we can re-land this.
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
…lutter#41736)" (flutter#41780)" (flutter#41795) This reverts commit 19c08e8. The attempted revert doesn't fix the problem, so we'll reland.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts c9d920f so that we can attempt to fix the build. The build dashboard clearly shows that things started failing at this change, although it's not totally clear that it is the cause: tests succeed locally.
If it doesn't fix things we can re-land this.