Skip to content

Reland "AOT support for Linux Desktop I: switch Linux builds to assemble"#42038

Merged
dnfield merged 1 commit intomasterfrom
revert-42030-revert-41612-aot_linux
Oct 7, 2019
Merged

Reland "AOT support for Linux Desktop I: switch Linux builds to assemble"#42038
dnfield merged 1 commit intomasterfrom
revert-42030-revert-41612-aot_linux

Conversation

@dnfield
Copy link
Copy Markdown
Contributor

@dnfield dnfield commented Oct 5, 2019

@dnfield dnfield requested a review from jonahwilliams October 5, 2019 03:23
@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 5, 2019
Copy link
Copy Markdown
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 5, 2019

Codecov Report

Merging #42038 into master will increase coverage by 0.09%.
The diff coverage is 60.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #42038      +/-   ##
==========================================
+ Coverage   59.57%   59.67%   +0.09%     
==========================================
  Files         194      194              
  Lines       18977    18981       +4     
==========================================
+ Hits        11306    11327      +21     
+ Misses       7671     7654      -17
Flag Coverage Δ
#flutter_tool 59.67% <60.97%> (+0.09%) ⬆️
Impacted Files Coverage Δ
...ackages/flutter_tools/lib/src/commands/unpack.dart 6.75% <10%> (+1.7%) ⬆️
...kages/flutter_tools/lib/src/commands/assemble.dart 80% <100%> (ø) ⬆️
...tter_tools/lib/src/build_system/targets/linux.dart 85.1% <76.66%> (-9.34%) ⬇️
...lutter_tools/lib/src/build_system/targets/web.dart 24.13% <0%> (-27.59%) ⬇️
...s/flutter_tools/lib/src/windows/visual_studio.dart 73.52% <0%> (-23.53%) ⬇️
...ges/flutter_tools/lib/src/application_package.dart 55.1% <0%> (-12.05%) ⬇️
...ter_tools/lib/src/fuchsia/application_package.dart 62.96% <0%> (-11.12%) ⬇️
packages/flutter_tools/lib/src/version.dart 91.9% <0%> (-1.43%) ⬇️
packages/flutter_tools/lib/src/artifacts.dart 70% <0%> (-1.38%) ⬇️
packages/flutter_tools/lib/src/cache.dart 45.41% <0%> (-1.12%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4b4616...1cfcee3. Read the comment docs.

@dnfield dnfield merged commit 3af1667 into master Oct 7, 2019
@dnfield dnfield deleted the revert-42030-revert-41612-aot_linux branch October 7, 2019 17:38
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants