Skip to content

Revert "Expose API for resizing image caches"#42764

Merged
jonahwilliams merged 1 commit intomasterfrom
revert-41415-exposeimage
Oct 15, 2019
Merged

Revert "Expose API for resizing image caches"#42764
jonahwilliams merged 1 commit intomasterfrom
revert-41415-exposeimage

Conversation

@jonahwilliams
Copy link
Copy Markdown
Contributor

@jonahwilliams jonahwilliams commented Oct 15, 2019

Reverts #41415

This is breaking on the web-test shard:

00:06 +11 ~15 -1: /tmp/flutter sdk/packages/flutter/test/painting/image_provider_test.dart: ResizeImage resizes to the correct dimensions                                                              
00:06 +11 ~15 -1: /tmp/flutter sdk/packages/flutter/test/painting/image_provider_test.dart: ResizeImage resizes to the correct dimensions [E]                                                          
  Expected: Size:<Size(14.0, 7.0)>
    Actual: Size:<Size(1.0, 1.0)>
  package:test_api                                   expect$
  package:flutter_test/src/widget_tester.dart 231:3  expect$
  image_provider_test.dart 312:5                     <fn>
  ===== asynchronous gap ===========================
  dart:sdk_internal                                  _async
  image_provider_test.dart 302:57                    <fn>
  ===== asynchronous gap ===========================
  package:stream_channel                             add
  image_provider_test.dart.browser_test.dart 56:17   <fn>

TBR @GaryQian

@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label Oct 15, 2019
@jonahwilliams jonahwilliams merged commit 7f8e89b into master Oct 15, 2019
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
@tvolkert tvolkert deleted the revert-41415-exposeimage branch December 3, 2019 18:49
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants