Skip to content

remove period from URL so that it opens correctly in vscode#43200

Merged
jonahwilliams merged 1 commit intoflutter:masterfrom
jonahwilliams:remove_period
Oct 21, 2019
Merged

remove period from URL so that it opens correctly in vscode#43200
jonahwilliams merged 1 commit intoflutter:masterfrom
jonahwilliams:remove_period

Conversation

@jonahwilliams
Copy link
Copy Markdown
Contributor

Description

vscode attempts to open a URL with a period at the end.

Fixes #43199

@jonahwilliams jonahwilliams requested a review from ferhatb October 21, 2019 19:46
@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 21, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 21, 2019

Codecov Report

Merging #43200 into master will decrease coverage by 1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #43200      +/-   ##
==========================================
- Coverage   61.13%   60.13%   -1.01%     
==========================================
  Files         195      195              
  Lines       18954    18942      -12     
==========================================
- Hits        11587    11390     -197     
- Misses       7367     7552     +185
Flag Coverage Δ
#flutter_tool 60.13% <100%> (-1.01%) ⬇️
Impacted Files Coverage Δ
...ools/lib/src/build_runner/resident_web_runner.dart 79.34% <100%> (ø) ⬆️
packages/flutter_tools/lib/src/ios/simulators.dart 3.26% <0%> (-47.29%) ⬇️
...ckages/flutter_tools/lib/src/ios/code_signing.dart 62.31% <0%> (-36.24%) ⬇️
packages/flutter_tools/lib/src/cache.dart 26.2% <0%> (-22.98%) ⬇️
...ckages/flutter_tools/lib/src/flutter_manifest.dart 77.94% <0%> (-6.67%) ⬇️
packages/flutter_tools/lib/src/version.dart 93.23% <0%> (-1.94%) ⬇️
...ges/flutter_tools/lib/src/application_package.dart 65.94% <0%> (-1.09%) ⬇️
packages/flutter_tools/lib/src/run_hot.dart 68.25% <0%> (-0.22%) ⬇️
packages/flutter_tools/lib/src/artifacts.dart 71.37% <0%> (+2.06%) ⬆️
packages/flutter_tools/lib/src/macos/xcode.dart 61.66% <0%> (+10%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 584ee10...6c527d8. Read the comment docs.

@jonahwilliams jonahwilliams merged commit 6db4c44 into flutter:master Oct 21, 2019
@jonahwilliams jonahwilliams deleted the remove_period branch October 21, 2019 23:43
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[web]: Flutter URL opens incorrectly in VS Code.

4 participants