Skip to content

Fake locale in doctor_test#44878

Merged
jmagman merged 1 commit intoflutter:masterfrom
jmagman:locale
Nov 14, 2019
Merged

Fake locale in doctor_test#44878
jmagman merged 1 commit intoflutter:masterfrom
jmagman:locale

Conversation

@jmagman
Copy link
Copy Markdown
Member

@jmagman jmagman commented Nov 14, 2019

Description

Fake out the doctor_test locale to account for locale variances between CI hosts.

12:32 +1590 ~5 -1: test/commands.shard/hermetic/doctor_test.dart: doctor with fake validators version checking does not work                                                                           
12:32 +1590 ~5 -1: test/commands.shard/hermetic/doctor_test.dart: doctor with fake validators version checking does not work [E]                                                                       
  Expected: 'Doctor summary (to see all details, run flutter doctor -v):\n'
              '[!] Flutter (Channel unknown, v0.0.0, on fake OS name and version, locale en-US)\n'
              '    ✗ version error\n'
              '\n'
              '! Doctor found issues in 1 category.\n'
              ''
    Actual: 'Doctor summary (to see all details, run flutter doctor -v):\n'
              '[!] Flutter (Channel unknown, v0.0.0, on fake OS name and version, locale en_US.UTF-8)\n'
              '    ✗ version error\n'
              '\n'
              '! Doctor found issues in 1 category.\n'
              ''
     Which: is different.
            Expected: ...  locale en-US)\n     ...
              Actual: ...  locale en_US.UTF-8) ...
                                    ^
             Differ at offset 137
  package:test_api                                                         expect
  org-dartlang-app:///test/commands.shard/hermetic/doctor_test.dart 529:7  main.<fn>.<fn>
  ===== asynchronous gap ===========================
  dart:async                                                               _asyncErrorWrapperHelper
  package:flutter_tools/src/base/context.dart                              AppContext.run
  org-dartlang-app:///test/src/context.dart 120:30                         testUsingContext.<fn>.<fn>.<fn>.<fn>
  dart:async                                                               runZoned
  org-dartlang-app:///test/src/context.dart 118:18                         testUsingContext.<fn>.<fn>.<fn>
  package:flutter_tools/src/base/context.dart 146:29                       AppContext.run.<fn>

Related Issues

Introduced with #44868.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 14, 2019
Copy link
Copy Markdown
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
Copy link
Copy Markdown
Member Author

jmagman commented Nov 14, 2019

Merging on red.

@jmagman jmagman merged commit 25b33a8 into flutter:master Nov 14, 2019
@jmagman jmagman deleted the locale branch November 14, 2019 03:08
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants