Skip to content

Revert "reland add lifecycle enum and fix the scheduleforcedframe"#45260

Merged
tvolkert merged 1 commit intomasterfrom
revert-45133-issues/39832-reland-with-workaround
Nov 20, 2019
Merged

Revert "reland add lifecycle enum and fix the scheduleforcedframe"#45260
tvolkert merged 1 commit intomasterfrom
revert-45133-issues/39832-reland-with-workaround

Conversation

@jonahwilliams
Copy link
Copy Markdown
Contributor

Reverts #45133

Fixes #45258. This change has stopped flutter applications based on the embedder API from rendering frames

@fluttergithubbot fluttergithubbot added framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Nov 20, 2019
@jonahwilliams
Copy link
Copy Markdown
Contributor Author

@gspencergoog @chunhtai is this safe to revert?

Copy link
Copy Markdown
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tvolkert tvolkert merged commit f20471d into master Nov 20, 2019
@tvolkert tvolkert deleted the revert-45133-issues/39832-reland-with-workaround branch November 20, 2019 17:43
chunhtai added a commit to chunhtai/flutter that referenced this pull request Jan 9, 2020
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Desktop apps no longer draw more than one frame.

5 participants