Fix analytics regression#46242
Merged
fluttergithubbot merged 3 commits intoflutter:masterfrom Dec 9, 2019
Merged
Conversation
fluttergithubbot
added
tool
christopherfujino
force-pushed
the
fix-analytics-regression
branch
from
7936576 to
fd6980b
Compare
zanderso
approved these changes
Dec 9, 2019
| } | ||
| devices = await findAllTargetDevices(); | ||
| if (devices == null) { | ||
| throwToolExit(null); |
Member
There was a problem hiding this comment.
Should this give a message like "Failed to find a target device" ?
Contributor
Author
There was a problem hiding this comment.
In findAllTargetDevices(), before returning null, the appropriate userMessages will be printed to stdout; in this case:
~/git/flutter/examples/hello_world$ flutter run
Building flutter tool...
No supported devices connected.So we're covered. I'll add a test verifying this (we have one for attach, but not for run) though.
Contributor
Author
There was a problem hiding this comment.
Added a test, PTAL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #45267, the tool stopped sending target device information on run command analytics events. This happened because the setting of
List<Device> deviceswas moved from the runvalidateCommand()method to therunCommand()method. However, the order of events in theverifyThenRunCommand()method is to:validateCommand()runCommand()This PR fixes the regression by moving the setting of
devicesback tovalidateCommand(), but changing the order of events inverifyThenRunCommand()to:validateCommand()runCommand()Related Issues
Fixes #46165.
Tests
I fixed the "updates before checking devices" test, and added a new test verifying that we send the command event with the proper device data.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].