Skip to content

[flutter_tool] Ensure dependency constraint for templates created with a driver test are correct#46643

Merged
jonahwilliams merged 1 commit intoflutter:masterfrom
jonahwilliams:fix_create_tests
Dec 10, 2019
Merged

[flutter_tool] Ensure dependency constraint for templates created with a driver test are correct#46643
jonahwilliams merged 1 commit intoflutter:masterfrom
jonahwilliams:fix_create_tests

Conversation

@jonahwilliams
Copy link
Copy Markdown
Contributor

Description

Because of the accidentally skipped tool tests, we missed updates to these tests when we bumped the test version and removed the facade classes from the module

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Dec 9, 2019
@jonahwilliams jonahwilliams requested a review from blasten December 9, 2019 23:05
Copy link
Copy Markdown

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonahwilliams jonahwilliams changed the title fix flutter create tests [flutter_tool] Ensure dependency constraint for templates created with a driver test are correct Dec 10, 2019
@jonahwilliams
Copy link
Copy Markdown
Contributor Author

Going to land on red to kick build

@jonahwilliams jonahwilliams merged commit a491697 into flutter:master Dec 10, 2019
@jonahwilliams jonahwilliams deleted the fix_create_tests branch December 10, 2019 01:32
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants