Skip to content

Revert "Add many more global analyses. (#47875)"#48080

Merged
franciscojma86 merged 1 commit intoflutter:masterfrom
franciscojma86:revert-analysis
Jan 2, 2020
Merged

Revert "Add many more global analyses. (#47875)"#48080
franciscojma86 merged 1 commit intoflutter:masterfrom
franciscojma86:revert-analysis

Conversation

@franciscojma86
Copy link
Copy Markdown
Contributor

@franciscojma86 franciscojma86 commented Jan 2, 2020 •
edited
Loading

This reverts commit e768c92.
This is breaking the build. TBR @Hixie

@franciscojma86 franciscojma86 requested a review from Hixie January 2, 2020 17:23
@fluttergithubbot fluttergithubbot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. customer: gallery Relating to flutter/gallery repository. Please transfer non-framework issues there. tool Affects the "flutter" command-line tool. See also t: labels. labels Jan 2, 2020
@franciscojma86 franciscojma86 merged commit 04ea318 into flutter:master Jan 2, 2020
@dnfield
Copy link
Copy Markdown
Contributor

dnfield commented Jan 2, 2020

LGTM

@dnfield
Copy link
Copy Markdown
Contributor

dnfield commented Jan 2, 2020

Actually maybe not. Can you link to the job that it broke? The only red I see on this commit is from an unrelated flake (#43763).

I think we should reland this. And in the future, can you include a link to the breakage in the message?

dnfield added a commit that referenced this pull request Jan 2, 2020
@dnfield
Revert "Revert "Add many more global analyses. (#47875)" (#48080)"
3fab9ad 
This reverts commit 04ea318.
@dnfield dnfield mentioned this pull request Jan 2, 2020
Merged
@franciscojma86
Copy link
Copy Markdown
Contributor Author

franciscojma86 commented Jan 2, 2020

Yeah that was the broken job.

And in the future, can you include a link to the breakage in the message?

Will do!

franciscojma86 pushed a commit that referenced this pull request Jan 2, 2020
@dnfield @franciscojma86
Revert "Revert "Add many more global analyses. (#47875)" (#48080)" (#…
24f39d4 
…48081)

This reverts commit 04ea318.
@franciscojma86 franciscojma86 deleted the revert-analysis branch January 21, 2020 21:15
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Hixie Hixie Awaiting requested review from Hixie

@jmagman jmagman Awaiting requested review from jmagman

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. customer: gallery Relating to flutter/gallery repository. Please transfer non-framework issues there. d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@franciscojma86 @dnfield @googlebot @fluttergithubbot