Skip to content

Reland "Add many more global analyses. (#47875)"#48081

Merged
franciscojma86 merged 1 commit intomasterfrom
revert-48080-revert-analysis
Jan 2, 2020
Merged

Reland "Add many more global analyses. (#47875)"#48081
franciscojma86 merged 1 commit intomasterfrom
revert-48080-revert-analysis

Conversation

@dnfield
Copy link
Copy Markdown
Contributor

@dnfield dnfield commented Jan 2, 2020

Reverts #48080

The failed CI on that appeared to be a flake (#43763)

@franciscojma86 @Hixie

@dnfield dnfield requested a review from jmagman as a code owner January 2, 2020 17:34
@fluttergithubbot fluttergithubbot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. customer: gallery Relating to flutter/gallery repository. Please transfer non-framework issues there. tool Affects the "flutter" command-line tool. See also t: labels. labels Jan 2, 2020
@franciscojma86 franciscojma86 self-requested a review January 2, 2020 17:35
@franciscojma86
Copy link
Copy Markdown
Contributor

franciscojma86 commented Jan 2, 2020

LGTM, sorry for the confusion!

@franciscojma86 franciscojma86 merged commit 24f39d4 into master Jan 2, 2020
@dnfield dnfield deleted the revert-48080-revert-analysis branch January 2, 2020 19:49
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jmagman jmagman Awaiting requested review from jmagman

1 more reviewer

@franciscojma86 franciscojma86 franciscojma86 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. customer: gallery Relating to flutter/gallery repository. Please transfer non-framework issues there. d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dnfield @franciscojma86 @googlebot @fluttergithubbot