Skip to content

make pub get test shufflable#48095

Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom
dnfield:pub_get_test
Jan 3, 2020
Merged

make pub get test shufflable#48095
fluttergithubbot merged 1 commit intoflutter:masterfrom
dnfield:pub_get_test

Conversation

@dnfield
Copy link
Copy Markdown
Contributor

@dnfield dnfield commented Jan 3, 2020

Fixes one of the failures in #47963

Makes sure to reset global state after each test.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 3, 2020
});

tearDown(() {
MockDirectory.findCache = false;
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gets set to true in some tests and never set back to false. False is default.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(this mock is local to this file)

Copy link
Copy Markdown
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit d7c347f into flutter:master Jan 3, 2020
@dnfield dnfield deleted the pub_get_test branch January 7, 2020 03:57
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants