[flutter_tools] Fix analytics opt out event#48585
Merged
zanderso merged 1 commit intoflutter:masterfrom Jan 10, 2020
zanderso:fix-analytics-opt-out
Merged
[flutter_tools] Fix analytics opt out event#48585zanderso merged 1 commit intoflutter:masterfrom zanderso:fix-analytics-opt-out
zanderso merged 1 commit intoflutter:masterfrom
zanderso:fix-analytics-opt-out
Conversation
zanderso
added
the
tool
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prior to this change, we toggled the flag before trying to send the event, which would lead to dropping events when toggling to false.
Tests
I added the following tests:
Fixed a test in config_test.dart, which didn't catch this due to the misuse of a mock.
Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].