Implement takeScreenshot and add driver test for Fuchsia#48611
Implement takeScreenshot and add driver test for Fuchsia#48611blasten merged 2 commits intoflutter:masterfrom
Conversation
a18149f to
aadb050
Compare
There was a problem hiding this comment.
Not super familiar with this flow, but it looks like you can set the file output name in the flutter screenshot command, but ResidentRunner.screenshot() hardcodes 'flutter.png'.
There was a problem hiding this comment.
If it sounds reasonable, I can follow up with adding a defaultScreenshotName to Device and then let ResidentRunner.screenshot() read the value.
There was a problem hiding this comment.
sg. it looks like the resident runner screenshot call is already using getUniqueFile, so Device might need both a defaultScreenshotName and a defaultScreenshotExt.
jonahwilliams
left a comment
There was a problem hiding this comment.
We shouldn't be committing any new binary files into the git repo. @Piinks might know if there is a way we could use skia gold here, or else it might require a secondary repo somewhere
|
@blasten and I talked offline. I believe there should be away to just plug in to the Gold dashboard. We might be able to use the |
aadb050 to
0a2f7d0
Compare
0a2f7d0 to
3adc791
Compare
|
PTAL |
There was a problem hiding this comment.
sg. it looks like the resident runner screenshot call is already using getUniqueFile, so Device might need both a defaultScreenshotName and a defaultScreenshotExt.
cc @iskakaushik