Skip to content

[flutter_tools] Handle special characters during conversion of asset manifest paths into URIs#48829

Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom
jason-simmons:manifest_asset_path_seg
Jan 16, 2020
Merged

[flutter_tools] Handle special characters during conversion of asset manifest paths into URIs#48829
fluttergithubbot merged 1 commit intoflutter:masterfrom
jason-simmons:manifest_asset_path_seg

Conversation

@jason-simmons
Copy link
Copy Markdown
Member

No description provided.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 14, 2020
@jonahwilliams
Copy link
Copy Markdown
Contributor

Adding @dnfield since he landed the previous fix

@jonahwilliams jonahwilliams requested a review from dnfield January 14, 2020 19:24
Copy link
Copy Markdown
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnfield
Copy link
Copy Markdown
Contributor

dnfield commented Jan 14, 2020

Is there a bug this is fixing for context?

@jason-simmons
Copy link
Copy Markdown
Member Author

While looking into #46163 I found that some characters that are meaningful in URIs were not being handled correctly in asset manifests (e.g. # and ?)

#46163 described a slightly different bug though.

@AlexV525
Copy link
Copy Markdown
Member

AlexV525 commented Jan 15, 2020

Would you like to add some chinese character in the test? Just to make sure everything will work properly. 😉

@fluttergithubbot fluttergithubbot merged commit 63016c8 into flutter:master Jan 16, 2020
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants