[flutter_tools] move dsym logic into dart#49491
Merged
jonahwilliams merged 3 commits intoflutter:masterfrom Jan 28, 2020
Merged
[flutter_tools] move dsym logic into dart#49491jonahwilliams merged 3 commits intoflutter:masterfrom
jonahwilliams merged 3 commits intoflutter:masterfrom
Conversation
fluttergithubbot
added
the
tool
added 2 commits
January 25, 2020 15:46
jmagman
reviewed
Jan 27, 2020
| final FlutterProject flutterProject = FlutterProject.current(); | ||
| final Target target = buildMode == BuildMode.profile | ||
| ? const AotAssemblyProfile() | ||
| : const AotAssemblyRelease(); |
Member
There was a problem hiding this comment.
When is AotAssemblyRelease being built with this change?
Contributor
Author
There was a problem hiding this comment.
I don't really like how it is set up right now. previously I created "bundle" targets that did nothing but depend on all of the individual parts - I can move towards that setup so that changes like this are less surprising
jmagman
reviewed
Jan 27, 2020
|
|
||
| @override | ||
| List<Target> get dependencies => const <Target>[ | ||
| AotAssemblyRelease() |
jmagman
approved these changes
Jan 27, 2020
Member
jmagman
left a comment
jmagman
left a comment
There was a problem hiding this comment.
Looks good [equivalent] to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove 13 lines of bash script and replace with an assemble target, add smoke test to dysm logic.