[flutter_tool] Hide unsafe std{out,err} operations#49561
Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom Jan 28, 2020
zanderso:io-hide-stdio
Merged
[flutter_tool] Hide unsafe std{out,err} operations#49561fluttergithubbot merged 1 commit intoflutter:masterfrom zanderso:io-hide-stdio
fluttergithubbot merged 1 commit intoflutter:masterfrom
zanderso:io-hide-stdio
Conversation
zanderso
added
tool
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a cleanup for #49380. In particular, it hides
stdoutandstderrinStdioinio.dart, and exposes only the functionality that we use.Tests
I added the following tests:
There was no change in functionality. Things we weren't using are now invisible/hidden by
io.dart.Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].