[flutter_tool] Make base/net.dart context free#49575
Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom Jan 28, 2020
zanderso:context-free-net
Merged
[flutter_tool] Make base/net.dart context free#49575fluttergithubbot merged 1 commit intoflutter:masterfrom zanderso:context-free-net
fluttergithubbot merged 1 commit intoflutter:masterfrom
zanderso:context-free-net
Conversation
zanderso
added
tool
| HttpClientFactory httpClientFactory, | ||
| @required Logger logger, | ||
| @required Platform platform, | ||
| }) : |
Contributor
There was a problem hiding this comment.
uber-nit: I don't love the formatting here. Of course, if you do it the other way then you end up odd indentation on the next lines.
Member
Author
There was a problem hiding this comment.
Yup. I was trying to avoid the odd indentation for the ':'
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes references to globals from
base/net.dart. Updates tests totestWithoutContext().Related Issues
#47161
Tests
I added the following tests:
Updated tests in
net_test.dart.Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].