Revert "[flutter_tools] remove alternative build aot code path"#49641
Merged
jonahwilliams merged 1 commit intomasterfrom Jan 28, 2020
Merged
Revert "[flutter_tools] remove alternative build aot code path"#49641jonahwilliams merged 1 commit intomasterfrom
jonahwilliams merged 1 commit intomasterfrom
Conversation
This reverts commit d1e25bf.
fluttergithubbot
added
c: contributor-productivity
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Contributor
Author
|
tbr @zanderso |
Member
|
lgtm |
Member
|
Looks like this change also broke some benchmarks in Dart's infrastructure, so we'll have to be sure to coordinate there too. @sortie |
Contributor
|
You can coordinate with the Dart VM team about these changes as they own the benchmarks. |
Contributor
Author
|
I might be easier to start with a warning before removing any functionality then, something like: "If you were going to run 'flutter build aot --..' instead run 'flutter assemble ... " |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #49577
android_compile_ devicelab failures, these tests are still using AOT