[web] Fix typo apple-mobile-web-app-status-bar-style#49894
Merged
fluttergithubbot merged 2 commits intoflutter:masterfrom Jan 31, 2020
Zazo032:patch-1
Merged
[web] Fix typo apple-mobile-web-app-status-bar-style#49894fluttergithubbot merged 2 commits intoflutter:masterfrom Zazo032:patch-1
fluttergithubbot merged 2 commits intoflutter:masterfrom
Zazo032:patch-1
Conversation
As you can see here: https://developer.apple.com/library/archive/documentation/AppleApplications/Reference/SafariHTMLRef/Articles/MetaTags.html, the `meta` tag is missing a `-app`.
Contributor
Author
|
@jonahwilliams also, would the addition of this block be interesting too? (maybe in another PR) <!-- Chromemeta tags -->
<meta name="theme-color" content="#ffffff">Not sure if Flutter currently supports a similar functionality: https://developers.google.com/web/fundamentals/design-and-ux/browser-customization |
Contributor
Sure! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As you can see here: https://developer.apple.com/library/archive/documentation/AppleApplications/Reference/SafariHTMLRef/Articles/MetaTags.html, the
metatag is missing a-app.