Skip to content

[flutter_tools] add missing period to end of filter#50038

Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom
jonahwilliams:fix_missing_period
Feb 3, 2020
Merged

[flutter_tools] add missing period to end of filter#50038
fluttergithubbot merged 1 commit intoflutter:masterfrom
jonahwilliams:fix_missing_period

Conversation

@jonahwilliams
Copy link
Copy Markdown
Contributor

Description

Output on module build:

jonahwilliams-macbookpro2:foo jonahwilliams$ flutter build ios-framework
Running "flutter pub get" in foo...                                 0.4s
Building frameworks for com.example.foo in debug mode...
 ├─Populating Flutter.framework...                                  0.2s
 ├─Adding placeholder App.framework for debug...                   155ms
 ├─Assembling Flutter resources for App.framework...                7.0s
 └─Moving to build/ios/framework/Debug                              0.0s
Building frameworks for com.example.foo in profile mode...
 ├─Populating Flutter.framework...                                  0.2s
 ├─Building Dart AOT for App.framework...                          20.0s
 ├─Assembling Flutter resources for App.framework...                0.1s
 └─Moving to build/ios/framework/Profile                            0.0s
Building frameworks for com.example.foo in release mode...
 ├─Populating Flutter.framework...                                  1.5s
 ├─Building Dart AOT for App.framework...                          16.2s
 ├─Assembling Flutter resources for App.framework...                0.1s
 └─Moving to build/ios/framework/Release                            0.0s
Frameworks written to /Users/jonahwilliams/Documents/foo/build/ios/framework.

@jonahwilliams jonahwilliams requested a review from jmagman February 3, 2020 21:05
@fluttergithubbot
Copy link
Copy Markdown
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 3, 2020
Copy link
Copy Markdown
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@fluttergithubbot fluttergithubbot merged commit b24bca1 into flutter:master Feb 3, 2020
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants