[flutter_tools] Small addition to the readme about testing#50051
Merged
zanderso merged 1 commit intoflutter:masterfrom Feb 4, 2020
zanderso:tool-readme
Merged
[flutter_tools] Small addition to the readme about testing#50051zanderso merged 1 commit intoflutter:masterfrom zanderso:tool-readme
zanderso merged 1 commit intoflutter:masterfrom
zanderso:tool-readme
Conversation
zanderso
added
c: contributor-productivity
Contributor
There was a problem hiding this comment.
Might be too strong, since a change which purely deletes code could reduce overall coverage - if that code was more tested than average. Perhaps we should say that the diff of the coverage should not be too far off of the average coverage?
Contributor
There was a problem hiding this comment.
I mean "coverage of diff" not "diff of coverage"
jonahwilliams
approved these changes
Feb 3, 2020
Contributor
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
Still LGTM, thanks!
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
Member
Author
|
Landing doc only change to kickstart a builder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the tool readme file with some additional information and links about testing.