[flutter_tools] Isolate userHomePath, other cleanups#50125
Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom Feb 5, 2020
zanderso:isolate-user-home-path
Merged
[flutter_tools] Isolate userHomePath, other cleanups#50125fluttergithubbot merged 1 commit intoflutter:masterfrom zanderso:isolate-user-home-path
fluttergithubbot merged 1 commit intoflutter:masterfrom
zanderso:isolate-user-home-path
Conversation
zanderso
added
tool
This was referenced Jun 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up to #49909 that moves
userHomePathfromFileSystemUtilstoConfig, which was its only user. It also removes references to the context fromPersistentToolState, and reworksConfigandPersistentToolStateto not depend onFileSystemUtils.Related Issues
#47161
Tests
I added the following tests:
Fixed
config_test.dartandpersistent_tool_state_test.dart.Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].