[flutter_tools] remove dependencies checks from gen_snapshot#50225
Merged
jonahwilliams merged 1 commit intoflutter:masterfrom Feb 6, 2020
Merged
[flutter_tools] remove dependencies checks from gen_snapshot#50225jonahwilliams merged 1 commit intoflutter:masterfrom
jonahwilliams merged 1 commit intoflutter:masterfrom
Conversation
…t in assemble-land
fluttergithubbot
added
the
tool
zanderso
approved these changes
Feb 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The depfile produced by the gen_snapshot wrapper code is no longer used, instead we rely on assemble APIs Target input/output/depfile to work. Now that both Android and iOS use assemble, there are no callers besides the direct usage of build aot. This direct usage doesn't need the depfile as it does not support any caching today.