Skip to content

Update compile size benchmarks#50313

Merged
jonahwilliams merged 2 commits intoflutter:masterfrom
jonahwilliams:update_ios_size_bench
Feb 7, 2020
Merged

Update compile size benchmarks#50313
jonahwilliams merged 2 commits intoflutter:masterfrom
jonahwilliams:update_ios_size_bench

Conversation

@jonahwilliams
Copy link
Copy Markdown
Contributor

Description

Use both tree-shake-icons and --split-debug-info for compile size tests

@fluttergithubbot
Copy link
Copy Markdown
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Feb 7, 2020
@jonahwilliams
Copy link
Copy Markdown
Contributor Author

This is a test 🤦‍♂

@jonahwilliams jonahwilliams requested a review from dnfield February 7, 2020 06:58
Copy link
Copy Markdown
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jonahwilliams jonahwilliams merged commit 7b07446 into flutter:master Feb 7, 2020
@jonahwilliams jonahwilliams deleted the update_ios_size_bench branch February 7, 2020 07:28
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants