Fix flutter doctor (pluginsPath) check for Mac#50324
Merged
fluttergithubbot merged 4 commits intoflutter:masterfrom Feb 26, 2020
Merged
Fix flutter doctor (pluginsPath) check for Mac#50324fluttergithubbot merged 4 commits intoflutter:masterfrom
fluttergithubbot merged 4 commits intoflutter:masterfrom
Conversation
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
fluttergithubbot
added
the
tool
c9n
changed the title
zanderso
reviewed
Feb 7, 2020
c9n
changed the title
zanderso
reviewed
Feb 11, 2020
Member
zanderso
left a comment
zanderso
left a comment
There was a problem hiding this comment.
Code looks good. Still needs a test.
Contributor
Author
Test added. |
zanderso
reviewed
Feb 13, 2020
Member
zanderso
left a comment
zanderso
left a comment
There was a problem hiding this comment.
Thanks for writing the test. On reading the change again, I noticed a couple of things.
Contributor
Author
|
@zanderso Is everything ok now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Flutter plugin & Dart plugin installation checking may fail when using
flutter doctoron Mac.However, they are both installed.
It failed just because it checked the wrong directory.
If you install IDEA via JetBrain ToolBox, the default plugin directory is something like this one:
So, we should read the Info.plist first then decide where to check for plugins.
flutter doctorafter fix ↓