Fix stack trace parsing on non-debug builds; add e2e tests#50652
Fix stack trace parsing on non-debug builds; add e2e tests#50652yjbanov merged 6 commits intoflutter:masterfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
b3416b4 to
8f1ac28
Compare
|
So everyone doesn't have to look at everything we can split the review into the following areas:
|
There was a problem hiding this comment.
Make this RegExp static
|
BTW, I'm still debugging these changes on Cirrus, but everything is passing on my local workstation so it should be good enough for review. |
There was a problem hiding this comment.
Specify it is only for chrome devtools
There was a problem hiding this comment.
Is it always going to be Chrome-only? How about "on browsers that support it"? This option is hidden anyway. The expectation is that the user knows what they are doing.
There was a problem hiding this comment.
Probably, I would still specify. This is documentation for the tools team too, someone who isn't experienced on the web isn't going to known chrome devtools vs other browsers
There was a problem hiding this comment.
Should be some existing tests for chrome, you'll want to verify that we use the right port in the launch command. I recomend something with FakeProcessManager.list([...expected launch command])
There was a problem hiding this comment.
note: since this only uses the version available on the system and on the engine we are running a pinned version, the results might be different.
Can you add a printout saying which version of chrome is being used? (If it is easy to do)
Therefore if something fails unexpectedly we can also compare the versions by looking at the log.
|
Debug stack trace fix in #50680 |
2af72d8 to
0c0b4c4
Compare
e64f2e3 to
58b48ea
Compare
Description
Fix stack trace parsing on non-debug builds; add e2e tests.
Related Issues
Fixes #48909
Tests
I added the following tests:
dev/integration_tests/web/lib/stack_trace.dart, an integration test that checks our ability to parse stack traces in debug, profile, and release modes.Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.