Skip to content

Generate a Property Sheet for Windows plugins#50740

Merged
stuartmorgan-g merged 2 commits intoflutter:masterfrom
stuartmorgan-g:windows-plugins-props
Feb 13, 2020
Merged

Generate a Property Sheet for Windows plugins#50740
stuartmorgan-g merged 2 commits intoflutter:masterfrom
stuartmorgan-g:windows-plugins-props

Conversation

@stuartmorgan-g
Copy link
Copy Markdown
Contributor

Description

Generates a Property Sheet for Windows builds containing link and include path
information for any included plugins. This allows automating part of the process
of integrating plugins into the build that is currently manual.

To support this change, refactored msbuild_utils into a PropertySheet class so that
it can be used to make different property sheets.

Related Issues

#32719

Tests

I added the following tests:

  • Tests of the new PropertySheet class
  • Tests that the new property sheet is created as expected by the plugin codepaths
  • Tests that the plugin registrant is generated on Windows (not directly related to
    this change, but I noticed they are missing, and it's in the same domain).

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 13, 2020
Copy link
Copy Markdown
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g merged commit f4177a6 into flutter:master Feb 13, 2020
@stuartmorgan-g stuartmorgan-g deleted the windows-plugins-props branch February 13, 2020 20:53
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants