[flutter_tools] use uri resolution for asset requests#50844
Merged
fluttergithubbot merged 3 commits intoflutter:masterfrom Feb 15, 2020
Merged
[flutter_tools] use uri resolution for asset requests#50844fluttergithubbot merged 3 commits intoflutter:masterfrom
fluttergithubbot merged 3 commits intoflutter:masterfrom
Conversation
fluttergithubbot
added
the
tool
harryterkelsen
approved these changes
Feb 15, 2020
| })); | ||
|
|
||
| test('serves asset files from in filesystem with url-encoded paths', () => testbed.run(() async { | ||
| final File source = globals.fs.file(globals.fs.path.join('build', 'flutter_assets', Uri.encodeFull('abcd象形字.md'))) |
Contributor
There was a problem hiding this comment.
extreme nit: maybe change the extension to .png instead of .md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The debug flutter run server was not properly accounting for URI encoded assets. See: flutter/engine#16630
Instead of path munging, use Uri.resolve