Skip to content

[flutter_tools] include depfile outputs in gradle outputs#50877

Merged
jonahwilliams merged 1 commit intoflutter:masterfrom
jonahwilliams:add_gradle_outputs
Feb 20, 2020
Merged

[flutter_tools] include depfile outputs in gradle outputs#50877
jonahwilliams merged 1 commit intoflutter:masterfrom
jonahwilliams:add_gradle_outputs

Conversation

@jonahwilliams
Copy link
Copy Markdown
Contributor

Description

I'm not sure if this is strictly necessary for gradle correctness. Currently we only include the depfile in the output set. Since we already have the complete set of outputs from the depfile, we can include those too

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 15, 2020
Copy link
Copy Markdown
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams merged commit 3cee8e0 into flutter:master Feb 20, 2020
@jonahwilliams jonahwilliams deleted the add_gradle_outputs branch February 20, 2020 21:24
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants