Ensure to close connection to VM after collecting coverage#50943
Merged
jmagman merged 3 commits intoflutter:masterfrom Feb 18, 2020
Merged
Ensure to close connection to VM after collecting coverage#50943jmagman merged 3 commits intoflutter:masterfrom
jmagman merged 3 commits intoflutter:masterfrom
Conversation
This avoids having many unused conections open. Each connection can hang on to a significant amount of memory, not closing them is effectively a big memory leak. This should reduce the memory consumption of `tool/tool_coverage.dart` Issue dart-lang/sdk#40627
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
fluttergithubbot
added
the
tool
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids having many unused conections open. Each connection can hang
on to a significant amount of memory, not closing them is effectively a
big memory leak.
This should reduce the memory consumption of
tool/tool_coverage.dartIssue dart-lang/sdk#40627