Skip to content

Revert "[flutter_tools] move engine unpack to the flutter tool (#50707)"#51076

Merged
franciscojma86 merged 1 commit intoflutter:masterfrom
franciscojma86:revert
Feb 19, 2020
Merged

Revert "[flutter_tools] move engine unpack to the flutter tool (#50707)"#51076
franciscojma86 merged 1 commit intoflutter:masterfrom
franciscojma86:revert

Conversation

@franciscojma86
Copy link
Copy Markdown
Contributor

This change breaks CI with error

/home/cirrus/sdks/flutter/packages/flutter_tools/lib/src/build_system/targets/ios.dart:81:13: Error: The method 'writeToFile' isn't defined for the class 'Depfile'.

TBR @jonahwilliams

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 19, 2020
Copy link
Copy Markdown
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@franciscojma86 franciscojma86 merged commit 6815e72 into flutter:master Feb 19, 2020
@franciscojma86
Copy link
Copy Markdown
Contributor Author

Landed on red to fix the tree

@jonahwilliams
Copy link
Copy Markdown
Contributor

Thanks!

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants