Reduce duration of benchmark to avoid timeout#51214
Merged
dnfield merged 3 commits intoflutter:masterfrom Feb 21, 2020
Merged
Conversation
fluttergithubbot
added
the
c: contributor-productivity
Contributor
Author
|
Ahh this is still timing out locally, spoke too soon. |
Contributor
Author
|
Ok, 5 is the right magic number to have it not timeout - and I manually verified that it still captures the important part fo when the benchmark is doing work. |
Contributor
Author
|
Going to land this on red to see if it deflakes the flaky benchmark. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test is timing out because it's running for too long - it only has 30 seconds t ocomplete, letting the main benchmark portion go for 15 seconds makes it timeout.
Once the test has passed a few times I'll remove the flaky flag.
/cc @jonahwilliams @liyuqian