[flutter_tools] don't fix chrome window size, add more logs#51346
Merged
jonahwilliams merged 2 commits intoflutter:masterfrom Feb 24, 2020
Merged
[flutter_tools] don't fix chrome window size, add more logs#51346jonahwilliams merged 2 commits intoflutter:masterfrom
jonahwilliams merged 2 commits intoflutter:masterfrom
Conversation
fluttergithubbot
added
the
tool
yjbanov
approved these changes
Feb 24, 2020
| .firstWhere((String line) => line.startsWith('DevTools listening'), orElse: () { | ||
| return 'Failed to spawn stderr'; | ||
| }) | ||
| .timeout(const Duration(seconds: 60), onTimeout: () { |
Contributor
There was a problem hiding this comment.
Aren't we avoiding timeouts in our system?
Contributor
There was a problem hiding this comment.
I guess if it takes between 50 and 70 seconds it could make tests flaky?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The addition of the window size param causes flutter run -d chrome to always launch in a large size. Also adds some extra logging to help debug the start failures.