Skip to content

[flutter_tools] Rework iOS vmservice handshake failure usage event#51419

Merged
zanderso merged 1 commit intoflutter:masterfrom
zanderso:ios-handshake-port
Feb 25, 2020
Merged

[flutter_tools] Rework iOS vmservice handshake failure usage event#51419
zanderso merged 1 commit intoflutter:masterfrom
zanderso:ios-handshake-port

Conversation

@zanderso
Copy link
Copy Markdown
Member

@zanderso zanderso commented Feb 25, 2020

Description

Improves the ios-handshake/failure event:

  • Reports the device-side port instead of the host-side port.
  • Stops reporting the port as an event value.
  • Uses different event actions for different failure kinds.
  • Filters uri out of HttpException for the event label to focus on potential problematic device-side ports.

Related Issues

Making analytics data more useful.

Tests

I added the following tests:

Updated existing tests.

Breaking Change

Did any tests fail when you ran them? Please read [Handling breaking changes].

  • No, no existing tests failed, so this is not a breaking change.

@zanderso zanderso added tool Affects the "flutter" command-line tool. See also t: labels. platform-ios iOS applications specifically labels Feb 25, 2020
jonahwilliams
jonahwilliams approved these changes Feb 25, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

christopherfujino
christopherfujino approved these changes Feb 25, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zanderso zanderso merged commit d73dd6b into flutter:master Feb 25, 2020
@zanderso zanderso deleted the ios-handshake-port branch February 25, 2020 20:22
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zanderso @christopherfujino @jonahwilliams @jmagman