Skip to content

fix pom file not found when run app with local engine#51468

Merged
fluttergithubbot merged 2 commits intoflutter:masterfrom
zsunkun:fix_pom_not_found_with_local_engine
Mar 3, 2020
Merged

fix pom file not found when run app with local engine#51468
fluttergithubbot merged 2 commits intoflutter:masterfrom
zsunkun:fix_pom_not_found_with_local_engine

Conversation

@zsunkun
Copy link
Copy Markdown
Contributor

@zsunkun zsunkun commented Feb 26, 2020

Description

When I run app with local engine,I get the following error:

Launching lib/main.dart on MI 6X in debug mode...
The file /Users/xxx/engine/src/out/android_debug/arm64_v8a_debug.pom wasn't found in the local engine out directory.

This is the content of my android_debug directory,it only has armeabi_v7a_debug.pom:
image

After fixed it, I got another problem:

* What went wrong:                                                      
Could not determine the dependencies of task ':app:compileDebugJavaWithJavac'.
> Could not resolve all task dependencies for configuration ':app:debugCompileClasspath'.
   > Could not find any matches for io.flutter:arm64_v8a_debug:+ as no versions of io.flutter:arm64_v8a_debug are available.
     Required by:                                                       
         project :app 

The reason for both issues is that getting the pom name and target-platform are both dependent on my phone(arm64). I think when using a local Engine, it should depend on the engine out path

flutter dcotor:

Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel v1.12.13-hotfixes, v1.12.13+hotfix.8, on Mac OS X 10.14.6 18G103, locale zh-Hans-CN)
[!] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    ✗ Android license status unknown.
      Try re-installing or updating your Android SDK Manager.
      See https://developer.android.com/studio/#downloads or visit https://flutter.dev/setup/#android-setup for detailed instructions.
[✓] Xcode - develop for iOS and macOS (Xcode 11.3)
[✓] Android Studio (version 3.5)
[✓] Connected device (1 available)

Related Issues

Tests

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read [Handling breaking changes].

  • No, no existing tests failed, so this is not a breaking change.

Fixes #48276

@fluttergithubbot
Copy link
Copy Markdown
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 26, 2020
@jonahwilliams
Copy link
Copy Markdown
Contributor

FYI @xster @blasten

@blasten
Copy link
Copy Markdown

blasten commented Feb 26, 2020

Thanks @zsunkun. This LG, but what about adding some unit tests in gradle_test.dart?

@jmagman
Copy link
Copy Markdown
Member

jmagman commented Feb 27, 2020

build_apk_test test failures need to be addressed as well as new tests added.
https://cirrus-ci.com/task/4736705525710848?command=main#L818

@jmagman jmagman added the waiting for response The Flutter team cannot make further progress on this issue until the original reporter responds label Feb 27, 2020
@zsunkun zsunkun force-pushed the fix_pom_not_found_with_local_engine branch from bb375a5 to 5a6f27e Compare February 28, 2020 11:30
@zsunkun
Copy link
Copy Markdown
Contributor Author

zsunkun commented Feb 28, 2020

build_apk_test test failures need to be addressed as well as new tests added.
https://cirrus-ci.com/task/4736705525710848?command=main#L818

@jmagman @blasten Unit tests have been updated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth testing each platform as well.

@zsunkun zsunkun force-pushed the fix_pom_not_found_with_local_engine branch from 5a6f27e to 4b0ec18 Compare March 2, 2020 07:24
@zsunkun zsunkun force-pushed the fix_pom_not_found_with_local_engine branch from 4b0ec18 to f773eb6 Compare March 2, 2020 08:39
@zsunkun zsunkun force-pushed the fix_pom_not_found_with_local_engine branch from f773eb6 to 37e616f Compare March 2, 2020 08:53
@zsunkun zsunkun requested a review from blasten March 3, 2020 01:54
Copy link
Copy Markdown

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit fdbd1b1 into flutter:master Mar 3, 2020
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels. waiting for response The Flutter team cannot make further progress on this issue until the original reporter responds

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Local engine run on android_debug_unopt_x64 doesn't find POM

6 participants