fix pom file not found when run app with local engine#51468
Merged
fluttergithubbot merged 2 commits intoflutter:masterfrom Mar 3, 2020
Merged
fix pom file not found when run app with local engine#51468fluttergithubbot merged 2 commits intoflutter:masterfrom
fluttergithubbot merged 2 commits intoflutter:masterfrom
Conversation
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Contributor
|
Thanks @zsunkun. This LG, but what about adding some unit tests in |
Member
|
|
bb375a5 to
5a6f27e
Compare
Contributor
Author
|
blasten
reviewed
Feb 28, 2020
There was a problem hiding this comment.
It might be worth testing each platform as well.
5a6f27e to
4b0ec18
Compare
4b0ec18 to
f773eb6
Compare
f773eb6 to
37e616f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When I run app with local engine,I get the following error:
This is the content of my android_debug directory,it only has armeabi_v7a_debug.pom:

After fixed it, I got another problem:
The reason for both issues is that getting the pom name and target-platform are both dependent on my phone(arm64). I think when using a local Engine, it should depend on the engine out path
flutter dcotor:
Related Issues
Tests
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].
Fixes #48276