Clean App.framework, Generated.xcconfig, flutter_export_environment.sh#51532
Merged
jmagman merged 2 commits intoflutter:masterfrom Feb 27, 2020
Merged
Clean App.framework, Generated.xcconfig, flutter_export_environment.sh#51532jmagman merged 2 commits intoflutter:masterfrom
jmagman merged 2 commits intoflutter:masterfrom
Conversation
fluttergithubbot
added
the
tool
jmagman
commented
Feb 27, 2020
| result.stdout.contains('there are two concurrent builds running'); | ||
| } | ||
|
|
||
| String readGeneratedXcconfig(String appPath) { |
jmagman
commented
Feb 27, 2020
| void cleanWorkspace(String workspacePath, String scheme) { | ||
| _processUtils.runSync(<String>[ | ||
| Future<void> cleanWorkspace(String workspacePath, String scheme) async { | ||
| await _processUtils.run(<String>[ |
Member
Author
There was a problem hiding this comment.
This takes awhile, spinner was stuck.
jmagman
commented
Feb 27, 2020
|
|
||
| deleteFile(flutterProject.dartTool); | ||
|
|
||
| final Directory androidEphemeralDirectory = flutterProject.android.ephemeralDirectory; |
Member
Author
There was a problem hiding this comment.
Remove the locals for readability (when does that ever happen!?)
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mitigate #50568 by removing the old
App.frameworkduringflutter cleanso users can get unstuck.Also remove
Generated.xcconfigandflutter_export_environment.shwhile we're at it.Related Issues
Mitigates #50568. Much safer potential hotfix than bigger fix at #51453.
Part of #12631.
Tests
Updated xcodeproj_test, clean_test.
Followed the very smart advice in #12631 (comment)
Checklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change