[flutter_tools] allow configuring libraries spec path for the web compilation#51590
Merged
fluttergithubbot merged 6 commits intoflutter:masterfrom Feb 28, 2020
Conversation
fluttergithubbot
added
tool
added 3 commits
February 27, 2020 14:02
zanderso
reviewed
Feb 28, 2020
| )).generator as DefaultResidentCompiler; | ||
|
|
||
| expect(residentCompiler.librariesSpec, | ||
| globals.fs.file(globals.artifacts.getArtifactPath(Artifact.flutterWebLibrariesJson, mode: BuildMode.debug)) |
Member
There was a problem hiding this comment.
Why does this one pass a mode, but the call in resident_runner.dart doesnt?
Contributor
Author
There was a problem hiding this comment.
Good point, It shouldn't be necessary - removed
zanderso
approved these changes
Feb 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pass libraries-spec URI to the frontend_server for web builds. Fixes #50801
For a real integration test, we need a web driver integration with flutter run, since flutter test --platform=chrome uses a different compiler it won't fail if this is broken